Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devsecops/emvaldes/remote-branch #17022

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Conversation

emvaldes
Copy link
Collaborator

@emvaldes emvaldes commented Jan 8, 2025

This PR imports the GitHub Repository (Action): remote-branch

This PR does not fix any currently exploitable issue.

Checklist

Process

  • Are there licensing issues with any new dependencies introduced? No
  • Includes a summary of what a code reviewer should test/verify? No
  • Updated the release notes? No
  • Database changes are submitted as a separate PR? No
  • DevOps team has been notified if PR requires ops support? We are the team performing this PR

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints? No

  • Does this PR include changes in authentication and/or authorization of existing endpoints? No

  • Does this change introduce new dependencies that need vetting? No

  • Does this change require changes to our infrastructure? No

  • Does logging contain sensitive data? No

  • Does this PR include or remove any sensitive information itself? No

  • What are the potential security threats and mitigations? N/A

  • Have you ensured logging does not contain sensitive data? N/A

  • Have you received any additional approvals needed for this change? N/A

@emvaldes emvaldes added tech-debt Anything that is purely a technical issue and does not affect functionality github-actions Tracking GitHub Actions items reportstream DevSecOps Team Aq DevSecOps work label imported-project Imported External/Remote Repositories labels Jan 8, 2025
@emvaldes emvaldes self-assigned this Jan 8, 2025
@emvaldes emvaldes requested a review from a team as a code owner January 8, 2025 22:40
Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks around SHA pinning, GTG otherwise.

@emvaldes emvaldes requested a review from devopsmatt January 13, 2025 23:05
@emvaldes emvaldes changed the title Devsecops/emvaldes/remote branch devsecops/emvaldes/remote-branch Jan 14, 2025
@emvaldes emvaldes requested review from scott-aquia, bethbeza and a team and removed request for devopsmatt and scott-aquia January 14, 2025 16:40
@emvaldes emvaldes dismissed devopsmatt’s stale review January 14, 2025 17:02

it's already addressed as the result of what was requested in the review.

@emvaldes emvaldes requested a review from devopsmatt January 14, 2025 17:08
@emvaldes emvaldes removed request for a team and devopsmatt January 14, 2025 17:48
Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see/resolve inline comments

@emvaldes emvaldes requested a review from bethbeza January 14, 2025 18:21
@emvaldes emvaldes dismissed devopsmatt’s stale review January 14, 2025 18:23

This issue was already addressed.

Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If the tag is 1.0.1,, then please merge.

@emvaldes emvaldes merged commit 40e70d3 into main Jan 14, 2025
18 checks passed
@emvaldes emvaldes deleted the devsecops/emvaldes/remote-branch branch January 14, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevSecOps Team Aq DevSecOps work label github-actions Tracking GitHub Actions items imported-project Imported External/Remote Repositories reportstream tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants